Pods are preferentially scheduled to machines that meet the current session resources #2815
Conversation
volcano-sh-bot
added
the
size/M
wangyang0616
changed the title
wangyang0616
force-pushed
the
fix_node_score
branch
2 times, most recently
from
a15a408 to
73b0116
Compare
|
/priority important-soon |
volcano-sh-bot
added
the
priority/important-soon
wangyang0616
force-pushed
the
fix_node_score
branch
from
73b0116 to
2dcbdd8
Compare
|
Close the current pr, and fix the preemption problem through #2916 /close |
|
@wangyang0616: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The current pr was closed by mistake, reopen it. |
|
@wangyang0616: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wangyang0616
force-pushed
the
fix_node_score
branch
2 times, most recently
from
c841e5e to
041dfeb
Compare
| } | ||
| } | ||
|
|
||
| var node *api.NodeInfo |
There was a problem hiding this comment.
no need to define a new node variable.
| if bestNode != nil { | ||
| node = bestNode | ||
| } else { | ||
| klog.Errorf("task %s/%s allocate failed, bestNode is nil", task.Namespace, task.Name) |
There was a problem hiding this comment.
The codes between 249 - 255 are redundent.
There was a problem hiding this comment.
The code after line 250 uses node information for resource judgment, and it is necessary to ensure that the node pointer is not empty.
| } | ||
| switch { | ||
| case len(nodes) == 0: | ||
| klog.V(3).Infof("Task: %v, no matching node is found in the nodes list."+ |
There was a problem hiding this comment.
Here log level 3 is not so good. There will be too much log.
| @@ -195,28 +195,64 @@ func (alloc *Action) Execute(ssn *framework.Session) { | |||
| break | |||
| } | |||
|
|
|||
| var candidateNodes []*api.NodeInfo | |||
| // When scheduling pods, gradient scoring is performed on all nodes that are successfully filtered. | |||
There was a problem hiding this comment.
// Candidate nodes are divided into two gradients:
// - the first gradient node: a list of free nodes that satisfy the task resource request;
// - The second gradient node: the node list whose sum of node idle resources and future idle meets the task resource request;
// Score the first gradient node first. If the first gradient node meets the requirements, ignore the second gradient node list, otherwise, score the second echelon node and select the appropriate node.
wangyang0616
force-pushed
the
fix_node_score
branch
from
041dfeb to
0bfd8d1
Compare
…ources, and then consider machines that are satisfied with future resources Signed-off-by: wangyang <wangyang8126@gmail.com>
wangyang0616
force-pushed
the
fix_node_score
branch
from
0bfd8d1 to
5e48157
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
fix: #2782
Except that the binpack plugin has this problem, I understand that other algorithm plugins may encounter similar problems, such as task-topology, nodeorder, etc.
I was wondering if this generic problem could be solved by:
When allocate scores nodes, it divides nodes into two groups. One group is machines whose idle resources meet task resource requests, and the second group is futrue idle machines that meet task resource demands.
First, score the first group of machines, and if a suitable machine can be found, schedule the task to a suitable node; if the first group does not have a machine that meets the resource request, then score the second group of machines, and then select a suitable node for scheduling.
In this way, the pod can be dispatched to the machine that meets the resource requirements in the current session first, so that the pod will not be pending for a long time. If all the machines in the current session do not meet the requirements, it can also be scheduled to wait in the machine that meets the futrue idle.